kevincox added inline comments. INLINE COMMENTS
> Alphare wrote in status.rs:456 > `traverse` returns some `Cow::Owned`, I felt that it was simpler to share the > same return signature for all functions, but I can map the output, I guess. I can definitely see that this is a judgement call. However `.map(Cow::Borrowed)` is easy enough to write that I think it makes sense in this case. However both ways are acceptable. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7929/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7929 To: Alphare, #hg-reviewers, kevincox Cc: marmoute, kevincox, mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
