http://bugs.freedesktop.org/show_bug.cgi?id=7205
------- Comment #35 from [EMAIL PROTECTED] 2007-03-16 06:34 PST -------
The fix in comment #34 is OK, but the change in comment #33 breaks things.
I just tried a test case and confirmed that the fix in #33 is incorrect. I'll
have to double-check my !rb->Data changes from Mar 15 as well.
Checking rb->Data != NULL isn't the correct way to tell if a renderbuffer is
valid since some renderbuffer types may never use the rb->Data pointer. An
example is the front renderbuffer for the normal xlib driver: the rb->Data
pointer isn't used since we use an X Drawable handle instead to point to the
window we're drawing into.
In this code:
for (i = 0; i < ctx->DrawBuffer->_NumColorDrawBuffers[0]; i++) {
struct gl_renderbuffer *rb = ctx->DrawBuffer->_ColorDrawBuffers[0][i];
+ if (!rb || !rb->Data)
+ continue;
can you tell me if rb or rb->Data is null?
If rb is non-null, can you print *rb in gdb? Also, what is the value of the
array index 'i'?
Thanks.
--
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Mesa3d-dev mailing list
Mesa3d-dev@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
