Ahhh, I am a bad liar. The attached patch fixes the regressions.
-Marek
On Tue, Mar 2, 2010 at 2:08 AM, Marek Olšák <mar...@gmail.com> wrote:
> Hi Michal,
>
> This branch breaks 2 piglit tests with r300g:
>
> depthrange-clear
> texdepth
>
> However I haven't investigated these and won't get to them until the
> weekend. I personally don't mind fixing the regressions after the merge (but
> I'm not the maintainer of r300g). Anyway I'm glad to see
> bypass_vs_clip_and_viewport dying.
>
> -Marek
>
>
> On Mon, Mar 1, 2010 at 5:08 PM, michal <mic...@vmware.com> wrote:
>
>> Hi,
>>
>> This branch removes bypass_vs_clip_and_viewport flag from pipe
>> rasterizer state. The benefits of having this bit around were dubious
>> for everybody and burdensome for driver writers.
>>
>> All the utility code that relied on this flag have been rewritten to
>> pass vertex positions in clip space and set clip and viewport state. I
>> would like to ask the maintainers of u_blitter module to please test my
>> changes and provide feedback.
>>
>> Please review.
>>
>> Thanks.
>>
>>
>>
>> ------------------------------------------------------------------------------
>> Download Intel® Parallel Studio Eval
>> Try the new software tools for yourself. Speed compiling, find bugs
>> proactively, and fine-tune applications for parallel performance.
>> See why Intel Parallel Studio got high marks during beta.
>> http://p.sf.net/sfu/intel-sw-dev
>> _______________________________________________
>> Mesa3d-dev mailing list
>> Mesa3d-dev@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
>>
>
>
From fe8c9e902b3cb6392979aeecf03b17d303210eba Mon Sep 17 00:00:00 2001
From: =?utf-8?q?Marek=20Ol=C5=A1=C3=A1k?= <mar...@gmail.com>
Date: Tue, 2 Mar 2010 02:37:45 +0100
Subject: [PATCH] util/blitter: Fix the viewport transformation for Z coordinates
When clearing buffers, the depth is specified in the range [0, 1]
and should be passed through blitter "as is".
---
src/gallium/auxiliary/util/u_blitter.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/gallium/auxiliary/util/u_blitter.c b/src/gallium/auxiliary/util/u_blitter.c
index f93c69d..0ba09d3 100644
--- a/src/gallium/auxiliary/util/u_blitter.c
+++ b/src/gallium/auxiliary/util/u_blitter.c
@@ -320,11 +320,11 @@ static void blitter_set_rectangle(struct blitter_context_priv *ctx,
/* viewport */
ctx->viewport.scale[0] = 0.5f * width;
ctx->viewport.scale[1] = 0.5f * height;
- ctx->viewport.scale[2] = 0.5f;
+ ctx->viewport.scale[2] = 1.0f;
ctx->viewport.scale[3] = 1.0f;
ctx->viewport.translate[0] = 0.5f * width;
ctx->viewport.translate[1] = 0.5f * height;
- ctx->viewport.translate[2] = 0.5f;
+ ctx->viewport.translate[2] = 0.0f;
ctx->viewport.translate[3] = 0.0f;
ctx->pipe->set_viewport_state(ctx->pipe, &ctx->viewport);
--
1.6.3.3
------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Mesa3d-dev mailing list
Mesa3d-dev@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
