On Tue, Jan 17, 2006 at 02:15:25AM -0700, Philip Prindeville wrote: > Ok, some progress... I've installed the package, I'm running it currently. > > Anyone have any comments on it?
Yes: why do you remove the HELO argument in filter_sender? This means you're breaking compatibility for those who don't want to use filter_helo. I don't think that change is necessary? Also, your code assumes you cannot call smfi_setreply in the helo() callback, but that assumption is wrong. At least, it is according to the milter API documentation. It's probably very useful to set a reply after HELO! I wonder what the behaviour of your patch is when returning 421, other 4xx or 5xx error codes from HELO, to various other MTAs... have you tested anything like that? -- #!perl -wpl # mmfppfmpmmpp mmpffm <[EMAIL PROTECTED]> $p=3-2*/[^\W\dmpf_]/i;s.[a-z]{$p}.vec($f=join('',$p-1?chr(sub{$_[0]*9+$_[1]*3+ $_[2]}->(map{/p|f/i+/f/i}split//,$&)+97):qw(m p f)[map{((ord$&)%32-1)/$_%3}(9, 3,1)]),5,1)='`'lt$&;$f.eig; # Jan-Pieter Cornet _______________________________________________ NOTE: If there is a disclaimer or other legal boilerplate in the above message, it is NULL AND VOID. You may ignore it. Visit http://www.mimedefang.org and http://www.roaringpenguin.com MIMEDefang mailing list MIMEDefang@lists.roaringpenguin.com http://lists.roaringpenguin.com/mailman/listinfo/mimedefang