On Tue, 26 Jun 2018, Jacek Caban wrote:

I still need to run some test, but I it seems ready for review.

The important change is __forceinline. We add extern to GCC macro,
because that matches closer intended behaviour. clang supports
__forceinline itself if -fms-extensions is used, so we should just leave
it to the compiler in that case (also __ptr32, __unaligned and __w64, so
I changed them as well while I was at it). Without -fms-extensions,
__always_inline__ is expected and as far as I can tell (and my testing
conforms that), it matches intended behaviour without additional attributes.

Signed-off-by: Jacek Caban <ja...@codeweavers.com>
---
mingw-w64-headers/crt/_mingw.h.in | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

I think the patch is fine, but it took me a couple re-reads until I got the full explanation of the commit message.

I can try to put this patch through test building of a number of projects that I build with clang+mingw, I'll let you know how it goes.

// Martin

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Reply via email to