On 06/26/2018 01:56 PM, Liu Hao wrote: > 在 2018/6/26 19:33, Jacek Caban 写道: >> I did tests with c89 and c99 before submitting the patch (C++ is >> irrelevant, I don't change behaviour there). I'm also able to build >> Firefox with this patch (which in the past revealed a few inline >> problems, so that's a nice test). Is there anything in particular that >> you think we should test? >> >> Thanks, >> Jacek >> > Does compiling and linking the attached two files using the following > command result in multiple definition ? > > clang a.c b.c -std=c99 > > If we were defining `__forceinline` that way and compiling using GCC > this would result in multiple definitions of `ctime_r()`.
This fails, good catch. I wonder why my (similar) test did not fail. It needs deeper look, I will investigate. Thanks, Jacek ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
