On 24 March 2011 15:49, Jason McIntyre <j...@cava.myzen.co.uk> wrote: > On Thu, Mar 24, 2011 at 03:32:38PM +0100, David Vasek wrote: >> On Thu, 24 Mar 2011, Glen Anderson wrote: >> >> >A small change to the interactive commands section to make the >> >description of the 1 command more accurate. >> > >> >$ diff -u top.1 top.1.new >> >--- top.1 B B B Thu Mar 24 12:39:45 2011 >> >+++ top.1.new B Thu Mar 24 13:10:45 2011 >> >@@ -282,7 +282,7 @@ >> >.Sq P >> >interactive command. >> >.It 1 >> >-Display CPU statistics on a single line instead of a line per CPU. >> >+Toggle between a single line of CPU statistics and one line per CPU. >> >.It C >> >Toggle the display of process command line arguments. >> >.It d Ar count >> >> Accidentaly, I have been playing with top(1) yesterday and today too. What >> would you think about pointing out that in the first mentioned case the >> statistics are cumulative? >> >> Regards, >> David >> >> >> $ diff -u top.1 top.1.new >> --- top.1 B B B Thu Mar 24 12:39:45 2011 >> +++ top.1.new B Thu Mar 24 13:10:45 2011 >> @@ -282,7 +282,7 @@ >> .Sq P >> interactive command. >> .It 1 >> -Display CPU statistics on a single line instead of a line per CPU. >> +Toggle between a single line of cumulative CPU statistics and one line per >> CPU. >> .It C >> Toggle the display of process command line arguments. >> .It d Ar count >> > > i think this is better: > > Index: top.1 > =================================================================== > RCS file: /cvs/src/usr.bin/top/top.1,v > retrieving revision 1.57 > diff -u -r1.57 top.1 > --- top.1 B B B 10 Aug 2010 20:34:16 -0000 B B B 1.57 > +++ top.1 B B B 24 Mar 2011 15:49:01 -0000 > @@ -75,7 +75,7 @@ > B The options are as follows: > B .Bl -tag -width Ds > B .It Fl 1 > -Display CPU statistics on a single line instead of a line per CPU. > +Display CPU statistics on a single line instead of one line per CPU. > B .It Fl b > B Use > B .Em batch > @@ -282,7 +282,8 @@ > B .Sq P > B interactive command. > B .It 1 > -Display CPU statistics on a single line instead of a line per CPU. > +Toggle CPU statistics between a single line for all processors > +and one line per CPU. > B .It C > B Toggle the display of process command line arguments. > B .It d Ar count > >
I liked the idea of using an adjective when talking about the combined statistics however cumulative isn't really an accurate term and while ostensibly mean seems appropriate I'm unsure how top calculates that line on machines with CPUs of varying speeds. If it takes a mean of the percentages it's clearly misleading, if it does something a it cleverer use of the term mean is wrong. With this in mind I think the following tweak to Jason's suggestion would be best. $ diff -u top.1 top.1.new --- top.1 Thu Mar 24 12:39:45 2011 +++ top.1.new Thu Mar 24 17:59:30 2011 @@ -75,7 +75,8 @@ The options are as follows: .Bl -tag -width Ds .It Fl 1 -Display CPU statistics on a single line instead of a line per CPU. +Display CPU statistics for all processors on a single line instead of one +line per CPU. .It Fl b Use .Em batch @@ -282,7 +283,8 @@ .Sq P interactive command. .It 1 -Display CPU statistics on a single line instead of a line per CPU. +Toggle CPU statistics between a single line for all processors and one line +per CPU. .It C Toggle the display of process command line arguments. .It d Ar count
