Hi everybody, Here is an updated list after doing what I said yesterday. One nit: I count 25 instances in cgi.c, not 27.
// 27 cgi.c: all ok // 317: msg is only NULL when status == 200 // 351,353,379,405,409,421,425,497,499,527: compile-time string // constants and/or scriptname // 552: neither r[i].file nor req->q.manpath can be NULL if we got this far // 564,585,809,814: constants or cannot be NULL // 878: made it through validate_manpath // 915: req.q.manpath is set by caller // 1002,1149: compile-time string constant // 1163,1164,1169,1170: compile-time constant, dp cannot be NULL there // 1180: compile-time string constant // 4 dbm.c: all ok // 85,92,96,102: dbm_map(fname) won // 5 dbm_map.c: all ok // 60,73,80,87,97: open(fname) won // // 3 eqn.c: agree with Dariusz // 305: p cannot be NULL // 679: def->key is set above if def is NULL // 1077: eqnsyms[i].sym cannot be NULL So I guess I'll start on these next: 5 html.c: 20 main.c: 2 man.c: 2 man_html.c: 5 man_macro.c: ... and check you here: // 2 man_term.c: Please check me, too. 9 man_validate.c: 37 mandocdb.c: 2 manpath.c: 23 mansearch.c: 4 mdoc_html.c: // 10 mdoc_macro.c: 1 mdoc_man.c: 2 mdoc_term.c: 43 mdoc_validate.c: 6 read.c: 13 roff.c: // 1 tag.c: // 1 tbl_layout.c: // 1 tbl_opts.c: 6 term_ps.c: 11 tree.c: One thing I noticed in cgi.c, line 1015: what if there are multiple slashes at the head of path? I think this can happen unless I'm missing something. Pax, -A -- http://haqistan.net/~attila | att...@stalphonsos.com | 0x62A729CF
