On Wed, Oct 26, 2022 at 07:39:03PM +0200, Kalabic S. wrote:
> Hello @misc,
>
> I do not see a reason not to update OS version that vmt (kernel level
> implementation of VMware Tools) is advertising to VMware hypervisor from 32
> bit FreeBSD to 64 bit version.
>
> If for nothing else, there's clock running forward issue that appeared in
> 7.2 release and that is solved simply by manually specifying "FreeBSD
> 64-bit" instead of "FreeBSD 32-bit" for "Guest OS Version".
> - https://marc.info/?t=166674083700007&r=1&w=2
> - https://marc.info/?t=166630469300002&r=1&w=2
>
> Attached is a simple patch that I tested and that changes string "FreeBSD"
> to "FreeBSD-64" in a call to "SetGuestInfo" function on hypervisor and that
> accomplishes the task.
>
> What could be a drawback? Is author David Gwynne still active and can he
> give some feedback?
What versions of ESXi did you test this with?
Did you test both i386 OpenBSD VMs and amd64 ones on each version?
-ml
> Index: dev/pv/vmt.c
> ===================================================================
> RCS file: /cvs/src/sys/dev/pv/vmt.c,v
> retrieving revision 1.26
> diff -u -p -u -r1.26 vmt.c
> --- dev/pv/vmt.c 8 Sep 2022 10:22:06 -0000 1.26
> +++ dev/pv/vmt.c 26 Oct 2022 17:01:39 -0000
> @@ -633,7 +633,7 @@ vmt_update_guest_info(struct vmt_softc *
> */
>
> if (vm_rpc_send_rpci_tx(sc, "SetGuestInfo %d %s",
> - VM_GUEST_INFO_OS_NAME, "FreeBSD") != 0) {
> + VM_GUEST_INFO_OS_NAME, "FreeBSD-64") != 0) {
> DPRINTF("%s: unable to set guest OS", DEVNAME(sc));
> sc->sc_rpc_error = 1;
> }
