Albert Santoni wrote: > Sean, you said you fixed the original "scratch backwards and forwards > are at different rates bug" in fixes_scratch, but Owen said he already > fixed it in his branch. Owen didn't say anything about his fix > breaking existing controls or changing the way the scratch CO works, > so why don't we just use his fix?
My understanding is that he fixed it in his branch for vinyl control only and made no guarantees about breaking or fixing anything else. (https://bugs.launchpad.net/mixxx/+bug/519892/comments/5) We can't use that as-is because vinyl control depends on the deck being stopped (so scratch==1 and play==0 for normal play speed) while MIDI controllers currently require scratch==0 and play==1 for normal play speed. (This non-intuitive discrepancy is one reason for https://bugs.launchpad.net/bugs/530281) Changes made to the engine since 1.7 cause the original asymmetrical scratch problem in https://bugs.launchpad.net/mixxx/+bug/519892. It's probably possible with some hacking to make it work like 1.7, but I'd strongly recommend making that an optional behavior, having the scratch_enable method be default. Then we can add a temporary "old_scratch_behavior" CO which unmodified scripts just set to 1 on init, giving script writers time to tune for the new behavior and not holding up a release. (A big problem with this is that "old_scratch_behavior" would be program-wide (since there's just one RateControl,) so you couldn't use controllers whose scripts expect the old behavior and others that expect the new at the same time, unless the CO was set before each "scratch" operation and cleared after it, which would become unwieldy.) In light of all that, my recommendation is to just go with the scratch_enable behavior, fix VC so it works with it (which should be quite easy as mentioned before: https://bugs.launchpad.net/mixxx/+bug/519892/comments/14,) patch all MIDI scripts to add scratch_enable=0 anywhere scratch=0 and scratch_enable=1 where scratch!=0, merge fixes_scratch to trunk, and release another beta for people to test and report problems. (Most, if not all of which would be a forgotten scratch_enable setting/clearing.) Thoughts? Sincerely, Sean M. Pappalardo "D.J. Pegasus" Mixxx Developer ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev _______________________________________________ Mixxx-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mixxx-devel
