On Fri, 2015-07-31 at 19:24 +0200, Ferran Pujol Camins wrote: > > The skins are also inconsistent in the way they handle the fx. >
Yeah this is unfortunate but we've mostly decided to let them be inconsistent for now. My hope is that people will decide that one of the approaches is best and then we can standardize on it using the templating system. Does anyone see a drawback to copying Shade's fx approach for now? By the way I wouldn't be opposed to hiding the pingpong knob in Echo if it makes our lives easier :) :). > > As we don't have a polished fx workflow yet, I propose to just adopt > the same 2x2 fx approach Shade has. This way the skins will be > consistent and we avoid space issues. > > > 2015-07-31 18:44 GMT+02:00 Owen Williams <owilli...@mixxx.org>: > On Fri, 2015-07-31 at 18:19 +0200, Daniel Schürmann wrote: > > > > I am trying to keep the amount of work to a minimum to > expedite the > > release. > > > > How is this related to the view menu? > > Thanks to Jercaianu Adding a new view option is a 10 lines > patch > > around > https://github.com/mixxxdj/mixxx/blob/master/src/mixxx.cpp#L937 > > That's 10 lines after we've had a discussion about what the > option > should be, how it should be worded and translated, and what > the key > binding should be, and then testing, and then making sure the > other > skins still work... There's a lot more to implementing a > feature than > just the code. So for now, let's please just stick to working > with skin > files. > > Owen > > > > > ------------------------------------------------------------------------------ > _______________________________________________ > Get Mixxx, the #1 Free MP3 DJ Mixing software Today > http://mixxx.org > > > Mixxx-devel mailing list > Mixxx-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/mixxx-devel > > ------------------------------------------------------------------------------ _______________________________________________ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel
