I am trying to keep the amount of work to a minimum to expedite the release. I do think we need to unify our skins better, but I don't think those issue should block the release. If we try to unify everything now there will be a lot of ripple effects between skins that will slow things down too much. Therefore I think we should focus on making Deere as good as we can without touching code.
If you're interested in working on code, I'd urge you to spend time investigating the reported issues with our streaming capability failing after a period of time (https://bugs.launchpad.net/mixxx/+bug/1277274). That's the major code-related problem we have right now. Owen On Fri, 2015-07-31 at 08:00 +0200, Daniel Schürmann wrote: > Hi > I do not see any reason to consider the vie menu as frozen. > > It will limit us a lot if we are not allowed to touch the preferred > section for view options. > > > > The view menu already allows to enable options depending on the skin > capabilities. > > it is already possible to allow a feature in a single skin. > > > A valid reason for for a menu freeze would be i18n. > > But the issue is only shifted if we use untranslated buttons or inter > skin menus. > > Untranslated buttons might be hard to access by a new non English > speaking user. > > > > Form this point of view the view menu is the far better choice. > > It is translate-able and even if we add a new menu entry just before > the release there is a chance > > to get it translated for one or two languages. > > > The other aspect is the consistency across skins. > > If Deere introduces an option to like hiding the BPM values, it would > be no deal to copy > > such feature to Latenight and Shade. copying th inter skin menu will > likely not possible. > > > Any thoughts? > > > Kind regards, > > > Daniel > > > > > > > > > > 2015-07-31 2:34 GMT+02:00 Owen Williams <owilli...@mixxx.org>: > I'm going to be pretty hands-off with Deere and I'm hoping > other people > can step up and make changes. Jus has veto authority with > respect to > style changes, but in general it's more important that we > iterate the > skin quickly to get it in shape. > > In other words, patches welcome :) > > owen > > On Thu, 2015-07-30 at 19:20 -0500, Be wrote: > > If the skin options menu is removed, there should still be > some way to > > toggle at least some of those options. IMO the most > important option is > > toggling stacked waveforms. There is room in the bar at the > top for some > > option buttons. > > > > The "HEAD GAIN" text is brushing up against the left edge of > the "SPLIT > > CUE" button. > > > > The labels for the little red knobs in the effects racks are > way too > > small in single-effect view. > > > > The play icon is lonely in that button. It should either be > centered > > within the button or the button should also show a pause > icon. > > > > Tooltips are not showing for the small buttons to the right > of the > > overview waveform. > > > > On 07/30/2015 07:06 PM, Owen Williams wrote: > > > Please remember that the global view menu is frozen for > 1.12. From now > > > on any changes to Deere should be restricted to the skin > files only. > > > > > > One option is to push the skin menu to the next version > since we're not > > > going to add it to the other skins and that would be very > inconsistent. > > > > > > I agree with trying to increase text size if we can, > probably using the > > > font definitions we've used elsewhere. Knob labels should > be consistent > > > with LateNight where possible. > > > > > > On Thu, 2015-07-30 at 18:56 -0500, Be wrote: > > >> This is waaay better now. I like the use of knobs with > different colored > > >> notches. There text is more readable, but it is still a > bit too small. > > >> The buttons next to knobs are also too small. "Gain" > should be renamed > > >> to "Master gain" for clarity. > > >> > > >> I feel that the skin options panel is awkward. Those > controls should be > > >> moved to the global View menu. > > >> > > >> On 07/30/2015 10:09 AM, Owen Williams wrote: > > >>> I went ahead and merged in the deere-updates skin. I > took a look at it > > >>> and it's definitely an improvement, and although it has > issues I think > > >>> we can open it up to the larger developer group now. > > >>> > > >>> Thanks for this work! The menu is amazing. > > >>> > > >>> Owen > > >>> > > >>> On Fri, 2015-07-24 at 16:11 +0200, S.Brandt wrote: > > >>>> Hi, > > >>>> Deere maintainer here. > > >>>> My current dev branch: [1] > > >>>> Fixes (mostly) all bugs for the skin listed: [2] > > >>>> It merges cleanly [3], but i`ve submitted no PR yet > since it is still > > >>>> unfinished, some items on my todo. > > >>>> > > >>>> > > >>>> Unfortunately, time is an major issue. > > >>>> > > >>>> > > >>>> Suggestion? > > >>>> Test the skin in its current state and comment and/or > submit PR. > > >>>> > > >>>> > > >>>> [1]: > https://github.com/esbrandt/mixxx/tree/deere_updates > > >>>> [2]: > https://blueprints.launchpad.net/mixxx/+spec/1.12-skins > > >>>> [3]: > > >>>> > > https://github.com/mixxxdj/mixxx/compare/1.12...esbrandt:deere_updates?expand=1 > > >>>> ------------ > > >>>> S.Brandt > > >>>> Mixxx - Free Digital DJ Mixing Software > > >>>> www.mixxx.org | Get Involved > > >>>> > > >>>>> On Jul 23, 2015, at 8:28 PM, Ferran Pujol Camins > > >>>>> <ferranpujolcam...@gmail.com> wrote: > > >>>>> > > >>>>> Hello, I thought I could put some love to Deere. But > before I start > > >>>>> to commit things that may not be appropriate, I would > like to know > > >>>>> if there are any specific plans for it. Whose the > maintainer? Any > > >>>>> suggestions? > > >>>> > > >>>> > > >>>> > > ------------------------------------------------------------------------------ > > >>>> _______________________________________________ > > >>>> Get Mixxx, the #1 Free MP3 DJ Mixing software Today > > >>>> http://mixxx.org > > >>>> > > >>>> > > >>>> Mixxx-devel mailing list > > >>>> Mixxx-devel@lists.sourceforge.net > > >>>> > https://lists.sourceforge.net/lists/listinfo/mixxx-devel > > >>> > > >>> > > >>> > > >>> > > ------------------------------------------------------------------------------ > > >>> _______________________________________________ > > >>> Get Mixxx, the #1 Free MP3 DJ Mixing software Today > > >>> http://mixxx.org > > >>> > > >>> > > >>> Mixxx-devel mailing list > > >>> Mixxx-devel@lists.sourceforge.net > > >>> https://lists.sourceforge.net/lists/listinfo/mixxx-devel > > >>> > > >> > > >> > > ------------------------------------------------------------------------------ > > >> _______________________________________________ > > >> Get Mixxx, the #1 Free MP3 DJ Mixing software Today > > >> http://mixxx.org > > >> > > >> > > >> Mixxx-devel mailing list > > >> Mixxx-devel@lists.sourceforge.net > > >> https://lists.sourceforge.net/lists/listinfo/mixxx-devel > > >> > > >> > > > > > > > > > > > > > > > ------------------------------------------------------------------------------ > _______________________________________________ > Get Mixxx, the #1 Free MP3 DJ Mixing software Today > http://mixxx.org > > > Mixxx-devel mailing list > Mixxx-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/mixxx-devel > > > ------------------------------------------------------------------------------ _______________________________________________ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel
