Our replies interleaved ...
[2018-07-19 09:38] Vasilii Kolobkov <polezaivs...@ko5v.net>
>
> Thanks for the comments, Philipp!
>
> [2018-07-19 03:24 +0200] Philipp Takacs <phil...@bureaucracy.de>
> > [2018-07-18 23:13] Vasilii Kolobkov <polezaivs...@ko5v.net>
> > > diff --git a/test/runtest b/test/runtest
> > > index 9f35ade..37a23ac 100755
> > > --- a/test/runtest
> > > +++ b/test/runtest
> > > @@ -1,13 +1,15 @@
> > > #!/bin/sh
> > >
> > > set -e
> > >
> > > export MH_TEST_COMMON="$PWD/common.sh"
> > >
> > > +. ${MH_TEST_COMMON}
> > > +
> >
> > Would be nice if this patch would also remove the source in
> > the single tests.
>
> I do like it that way it is for it makes this dependency a bit more
> explicit. Let me know if you see no merit in it and i'll dump
> sourcing in each test.
As written in the other message: I'd favor to just have these helper
functions available in all tests (like we have all of sbr/ available
in all of uip/). It's a library thing ...
> > > diff --git a/test/tests/mhsign/test-mhsign b/test/tests/mhsign/test-mhsign
> > > index 3c2bb97..4f24b09 100755
> > > --- a/test/tests/mhsign/test-mhsign
> > > +++ b/test/tests/mhsign/test-mhsign
> > > @@ -3,14 +3,21 @@
> > > #
> > > # Test mhsign (correct alias expansion with -enc)
> > > #
> > > ######################################################
> > >
> > > . "$MH_TEST_COMMON"
> > >
> > > +phostname()
> > > +{
> > > + case `uname -s` in
> > > + OpenBSD) hostname ;;
> > > + *) hostname -f ;;
> > > + esac
> > > +}
> >
> > oh hostname, markus has summarised[3] this very good. I wouldn't
> > change the test, because it does exact the same as mhsing. Maybe
> > after fixing mhsign.
>
> I missed the mhsign(1) discussion, but do agree here. Though it'd
> have to be `hostname -f 2>/dev/null | uname -n` so no to fill the
> output with errors about unrecognized flag.
Yes, do so, but put the second pipe symbol in place again! ;-)
meillo
