Hi Greg,
>
> I also hot heard anything back from the poeple I sent a copy to, I can
> hence only assume that its so good that it's made them speachless ;-)
>
That's more a matter of time, then a matter of speach...
Greg, I have taken a look at your module and the code and I think it is
really worth publishing it.
I have three anonations:
1.)
$r->header_out(Location => $r->uri());
Also this code works with most browsers it doesn't conform to the HTTP
specs. A location header must include a host part. Shouldn't be to hard add
something like
$r->header_out(Location => 'http://' . $r -> server -> server_hostname .
$r->uri());
2.) You use global variables for configuration. While this is fast and easy
your aren't be able to have different configurations for different
directories or virtual hosts. From my point of view this is a must! I want
to only run SessionManager for certain directories and are able to use
different configurations for different applications.
I would highly recomend to use PerlSetVar for configuration.
3.) You have a hard coded make_session_id function. This function should be
customable i.e. calling a user defined function which returns a new session
id and there should be some way to interact with Apache::Session which
already have a (configurable) class that generates session ids. Before the
session id is send out to the browser, there must be some way to check if it
is valid i.e. doesn't already exists, because it can't be (easily) corrected
afterwards.
Gerald
-------------------------------------------------------------
Gerald Richter ecos electronic communication services gmbh
Internetconnect * Webserver/-design/-datenbanken * Consulting
Post: Tulpenstrasse 5 D-55276 Dienheim b. Mainz
E-Mail: [EMAIL PROTECTED] Voice: +49 6133 925151
WWW: http://www.ecos.de Fax: +49 6133 925152
-------------------------------------------------------------
