Steve Hay wrote: [...]
Steve, Randy, you haven't confirmed whether you want this patch to be in or not. Take your time to respond, of course.
Sorry, Stas - in the excitement over Bill's patch to fix Apache I completely forgot about your fix for mp2 running on unfixed Apache's.
I've tried it out now using 2.0.48 (under which 1.99_13's test suite would normally "hang" for me) and it successfully bumped up the ThreadsPerChild setting to 22 and the test suite all ran OK.
Is there any way to inspect what version of Apache we're using and only increment max_clients by vhost_listeners for version < 2.0.50?
yes, we know the version number (Apache::Test::config->server->{version})
It doesn't hurt to always do the increment, of course, but it might be useful from the point of view of testing Apache too if it wasn't done when it didn't need to be.
Thanks Steve.
Let's just drop that patch if 2.0.50 has it fixed. Normally it's only you and Randy that run mp2 tests on win32, and you now have a solution. If we ever find that it's really needed we have it in the archives.
__________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com
-- Report problems: http://perl.apache.org/bugs/ Mail list info: http://perl.apache.org/maillist/modperl.html List etiquette: http://perl.apache.org/maillist/email-etiquette.html
