Radoslaw Zielinski wrote:
Stas Bekman <[EMAIL PROTECTED]> [27-04-2004 00:15]:

Cool, so we have Radoslaw, who understands in glib/gnome and forwarded a

[...]


Uh, not really... :-)  I just poked around in the *.h files / libgtop's
documentation / changelogs and hacked it until it built.

And lots of thanks you for that!


Radoslaw, do you know how can we #ifdef on 2.0.6 in the C code? I spent hours trying to figure it out but in vain. The only way I see is to run


pkgconfig --modversion libgtop-2.0


Looks like a proper solution to me.


and then define our own define, which I did here:
http://apache.org/~stas/GTop-0.13.tar.gz (which is not quite working, because of the missing glibtop_free symbol.)


Changelog says, that all custom memory management routines have been
substituted by those from glib.  Therefore, glibtop_free became g_free.
I couldn't find any references to glibtop_free_r (I'm too lazy to search
in diffs between versions ;-), but it appears, that only the second
(IIRC) argument needs to be freed, so I used the g_free as well.


which Changelog you are reffering to? libgtop-2.0.6/ChangeLog from the source package doesn't mention anything like that. I need to know an exact version where this has happened so I can ifdef properly.


But yes, your patch is cool, we just need to ifdef to support older versions. The problem with ifdef is that there nothing to ifdef on, I couldn't find any version defines neither in ligtop, nor glib nor gnome. It looks like the only way to get versions is via an external program (what a horror).

Another change introduced by
http://apache.org/~stas/GTop-0.13.tar.gz
is that now pkgconfig --libs/--ccflags only tells you the glib requirements. so it broke everything on my machine since it was now finding glib-1.2 and glib-2.0, and trying to build against the former. That tar above handles that properly.


__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com

--
Report problems: http://perl.apache.org/bugs/
Mail list info: http://perl.apache.org/maillist/modperl.html
List etiquette: http://perl.apache.org/maillist/email-etiquette.html



Reply via email to