Radoslaw Zielinski wrote: [...]
define doesn't work for you. Check Server/Makefile.PL it loads config.pl and calls the code that should insert -DGTOP_2_5_PLUS define.
It works, error was elsewhere. I didn't built it "by hand", but by changing the version in the .spec file. It contained:
GTOP_LIB="`pkg-config --libs libgtop-2.0`" \ GTOP_INCLUDE="`pkg-config --cflags libgtop-2.0`" \ %{__perl} Makefile.PL \ INSTALLDIRS=vendor %{__make} \ OPTIMIZE="%{rpmcflags}" \ INC="`pkg-config --cflags libgtop-2.0`" \ EXTRALIBS="`pkg-config --libs libgtop-2.0`
After removing all (but INSTALLDIRS and OPTIMIZE) variable definitions, it worked fine. You assigned the -DGTOP_2_5_PLUS to INC; this caused the problem, as it was overwritten... I'd suggest using the DEFINE argument for WriteMakefile; patch attached.
An excellent suggestion, merged with a few tiny tweaks into the yet another snapshot (same url :)
http://apache.org/~stas/GTop-0.13.tar.gz
BTW #1: I never touched XS, but things like this always turn my "search
for memory leaks" warning on...
PERL_DL_NONLAZY=1 /usr/bin/perl5.8.4 [...]
t/basic......ok t/threads....ok 3/6Attempt to free unreferenced scalar: SV 0x8219bb8 during global destruction.
t/threads....ok 4/6Attempt to free unreferenced scalar: SV 0x8258008 during global destruction.
t/threads....ok 5/6Attempt to free unreferenced scalar: SV 0x822f660 during global destruction.
t/threads....ok All tests successful.
That's a bug in perl: http://rt.perl.org:80/rt3/Ticket/Display.html?id=24660 (the only way to see the ticket is by logging in :(
BTW #2: `perl -w Makefile.PL` looks rather messy... ;-)
Yeah, thanks. fixed all but this one:
Argument "" isn't numeric in numeric lt (<) at /usr/lib/perl5/5.8.3/ExtUtils/MakeMaker.pm line 390.
There is no numeric lt at that line. If you can take a look and report a bug to the makemaker list that would be great.
__________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com
-- Report problems: http://perl.apache.org/bugs/ Mail list info: http://perl.apache.org/maillist/modperl.html List etiquette: http://perl.apache.org/maillist/email-etiquette.html
