>
> Ok, first off, a lot of functions are left empty with no prototype declared,
> like f.ex. "void lame_init()", instead of doing it properly like
> "void lame_init(void)" .. doing this will eliminate about half of the compiler
> warnings (and also declaring prototypes in the appropriate .h file)...
>
I fixed some of these, but gcc doesn't complain about it even
with -Wall, so I'm sure I missed many of them.
> ..then there are lots and lots of dead assignments that probably are left over
> from old code and never got removed...
>
send me a patch :-)
>
> ..if you run LAME without arguments, you get two headers, which looks kinda
> silly, due to the fact that both lame_init() and lame_usage() prints them. ;)
>
fixed.
>
> In get_audio.c at line 369 (and 210) "if ((".." && (samples_read >= 0))" ..
> what is the purpose of this, as samples_read is a unsigned long, and thus can
> never be less than zero?!
>
This should probably be considered a bug, since samples_read is supposed
to be able to handle a -1 return value. I changed it to an int.
>
> In the compute_ath() function in loop.c (line 219) Min() is called twice with
> the function ATHformula() as one of it's arguments .. Calling min or max
> functions with functions as arguments is generally a Bad-Thing(tm), as you
> might end up changing values twice, or as in this case just wasting CPU time.
>
fixed.
--
MP3 ENCODER mailing list ( http://geek.rcc.se/mp3encoder/ )
