>> In get_audio.c at line 369 (and 210) "if ((".." && (samples_read >= 0))" ..
>> what is the purpose of this, as samples_read is a unsigned long, and thus
>> can never be less than zero?!
>This should probably be considered a bug, since samples_read is supposed
>to be able to handle a -1 return value. I changed it to an int.
Hmmm, I think you broke it .. you forgot a few things... ;)
1. Line 15: "DWORD getaudio(...)" .. ie, it still returns unsigned long (as
typedef'ed in common.h). ;)
2. Line 179 and 321: read_samples() returns int, but everything inside uses
unsigned long. ;)
- CISC
--
MP3 ENCODER mailing list ( http://geek.rcc.se/mp3encoder/ )
