>> Ok, first off, a lot of functions are left empty with no prototype
>> declared, like f.ex. "void lame_init()", instead of doing it properly like
>> "void lame_init(void)" .. doing this will eliminate about half of the
>> compiler warnings (and also declaring prototypes in the appropriate .h
>> file)...
>> ..then there are lots and lots of dead assignments that probably are left
>> over from old code and never got removed...
>send me a patch :-)
Ok, I'll go through all those warnings and fix them and send you a patch... ;)
>> In get_audio.c at line 369 (and 210) "if ((".." && (samples_read >= 0))" ..
>> what is the purpose of this, as samples_read is a unsigned long, and thus
>> can never be less than zero?!
>This should probably be considered a bug, since samples_read is supposed
>to be able to handle a -1 return value. I changed it to an int.
Heheh, ok, I thought that looked weird. ;)
- CISC
--
MP3 ENCODER mailing list ( http://geek.rcc.se/mp3encoder/ )
