>> o main.c can't hold lame_global_flags, change lame_init() to allocate and
>>   return a pointer to lame_global_flags.
>> o Move lame_global_flags out of lame.h, it should never be accessed
>> externally.
>I think we have to keep the old interface, since several applications
>use it.  So lame_global_flags will still have to be instantiated by the
>calling program and exposed to the calling program.  I dont think this
>is incompatiable with a shared library?

Yes, it is, because the structure itself can expand and change at any given
time internally, and if it's allocated and/or changed externally it will most
surely get corrupted by any program using a different version of the structure
than the library itself...


- CISC

--
MP3 ENCODER mailing list ( http://geek.rcc.se/mp3encoder/ )

Reply via email to