This applies to probably every lame, including the latest CVS.

The problem is that lame is very stubborn about setting the genre.  If
you specify an invalid genre, lame never falls back on a default (such
as "other").  This is annoying for scripts that use lame (such as my
project YaRET, shameless plug: http://www.nongnu.org/yaret/) since one
false move in user input causes the entire encoder to die.

Sure the scripts can be re-written to avoid this problem, but the rest
of the options (such as the year) do not cause such failures if
improperly specified.

Below is the minimum changes necessary to make lame work more
cosistantly.  I don't include more complex solutions (such as printing a
warning, or enabling this feature only if an additionally command line
option is given) because, as a mentioned, the other tags do not do
anything more complicated.

Ciao,
  Adam Luter

diff -r1.22 id3tag.c
133a134,135
> /* Default is "Other" */
> #define GENRE_DEFAULT 12
301c303
<                 return -1;
---
>                 num = GENRE_DEFAULT;
304c306
<             return -1;
---
>             num = GENRE_DEFAULT;

_______________________________________________
mp3encoder mailing list
[EMAIL PROTECTED]
http://minnie.tuhs.org/mailman/listinfo/mp3encoder

Reply via email to