On Mo, 2014-12-08 at 15:38 +0100, Jörg Krause wrote: > On Mo, 2014-12-08 at 14:22 +0100, Max Kellermann wrote: > > On 2014/12/07 22:40, Jörg Krause <jkra...@posteo.de> wrote: > > > This patch fix a build error with the musl C library. The patch is > > > originally > > > taken from Alpine Linux: > > > http://git.alpinelinux.org/cgit/aports/tree/main/mpd/fix-musl.patch. > > > > > > musl declares pthread_equal both as a macro and as a function. Without the > > > parentheses the preprocessor expands pthread_equal to ::((id)==(other.id)) > > > which obviously fails. > > > > > > Using parentheses prevents the preprocessor from expansion and the > > > compiler > > > looks up for the function declaration of pthread_equal in the global > > > namespace. > > > > I found it simpler to just drop the "::". It is sad that musl uses > > macros to implement the standard C API, though. > > Many thanks for the commits. I was really confused by the declaration of > pthread_equal both as macro and as function. I will ask the musl > maintainers about this.
FYI: This is the statement of a musl maintainer about this issue: http://www.openwall.com/lists/musl/2014/12/08/15 _______________________________________________ mpd-devel mailing list mpd-devel@musicpd.org http://mailman.blarg.de/listinfo/mpd-devel
