I've read through your code carefully, and made a list of things I want to check out when I merge it. The code looks good, in the sense that the algorithm obviously works.
I see lots of things that could be optimised, but they are all non- critical, in my opinion. And given the fact that it won't get all that much use, for the reasons I pointed out, it really isn't worth spending too much time optimising it further. Optimising the root tests themselves would probably be the best way to do any further optimisation now. I'm going to be getting back to MPIR coding next week, and whilst it won't be my number one priority, I'll try to get it merged in a spare moment. Thanks again for the contribution. Bill. On 24 Apr, 01:30, Bill Hart <goodwillh...@googlemail.com> wrote: > Hi Robert, > > You might find it interesting to look at the code in my other project, FLINT: > > http://www.flintlib.org/ > > In particular the functions in the file long_extras. There's lots of > stuff there for primality testing, implementing just about every > primality test you can think of for unsigned longs. A student of mine > (Peter Shrimpton) implemented much of it. > > Tom Boothby, a student at University of Washington is currently > working on speeding up the factoring code. > > Thanks for making additional changes to the code you submitted to > MPIR. I intend to read it thoroughly on Saturday. I'll probably email > you if I have questions. Can't wait to get it merged. > > Bill. > > 2009/4/24 gerrob <robert.gerb...@gmail.com>: > > > > > I've made some changes to the code. > > There are some new ideas speeding up the algorithm for very large/ > > critical input, but now I don't see any further possible improvements. > > > See the new code at google group, newperfpow2.c > > The old code is still there. --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "mpir-devel" group. To post to this group, send email to mpir-devel@googlegroups.com To unsubscribe from this group, send email to mpir-devel+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/mpir-devel?hl=en -~----------~----~----~----~------~----~------~--~---
