Thank you for the detailed information. I'll be changing my code
today. Like Michael Corleone, "Just when I thought I was out... they
pull me back in." I was very comfortable in my Qt 5.4 environment, but
exactly 1 day before the master switched to 5.6, I was notified of some
issues with code I had modified. To enable a simple (barely any code
changed) PR the next day, I had to upgrade. Now I'm stuck, forced to
use the latest master code now, not at some future time of my choosing.
I'm not complaining, just explaining my personal sense of urgency about
this question (and possibly future questions). I don't mind
contributing to QA testing and making unplanned changes - that's just
how it is some times in the Open Source world. It's part of the price
you pay for "free" software.
Thanks again for the clearly stated response.
--
James
On 4/22/2016 3:07 AM, Werner Schweer wrote:
_distanceUp and _distanceDown are gone and will not come back. The
staff distance is now calculated in System->layout2()
and the system distance in Score->collectPage() which calls layoutPage().
The distance between systems can be determined by looking at
system->pos().y().
SysStaff->_distanceUp/Down was used to collect information from
layouting elements like fret symbols etc. which might increase
the staff distance. This is replaced by a more generic algorithm which
uses the Shape of staves to determine the minimum distance without
any collision.
Am 21.04.2016 um 20:43 schrieb Sideways Skullfinger:
I submitted this question to the list 5 days ago, and there has been
no response, so I wanted to try again. Is there a replacement for
SysStaff::distanceUp() and distanceDown() in the latest master code?
Thanks,
Sideways
On 4/16/2016 12:29 PM, Sideways Skullfinger wrote:
2.0.3 source code here:
https://github.com/musescore/MuseScore/blob/2.0.3/libmscore/system.h#L48
The 2.0.3 class SysStaff looks like this:
class SysStaff {
QRectF _bbox; ///< Bbox of StaffLines.
qreal _yOff; ///< offset of top staff line within bbox
qreal _distanceUp; ///< distance to previous staff
qreal _distanceDown; ///< distance to next staff
bool _show; ///< derived from Staff or false if empty
...
The current master has removed these variables and commented-out
lines where the public properties for these variables are called,
sometimes with a "TODO" in the comment.
I use SysStaff::distanceDown() and SysStaff::distanceUp() in my
code, and now I have no substitute for it. What is the plan here?
How should I be determining the distance between staves?
I posted this same thing on the musescore forums here:
https://musescore.org/en/node/106501
Thanks,
Sideways
------------------------------------------------------------------------------
Find and fix application performance issues faster with Applications Manager
Applications Manager provides deep performance insights into multiple tiers of
your business applications. It resolves application problems quickly and
reduces your MTTR. Get your free trial!
https://ad.doubleclick.net/ddm/clk/302982198;130105516;z
_______________________________________________
Mscore-developer mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mscore-developer
