On 2009/02/10 14:56, Romain Bignon <rom...@peerfuse.org> wrote: > Ok, so my first fix fixes the second problem too :) > > I send you the first patch fixed. > > Is the second patch ok for you?
Your patch "can shuffle selected list" looks ok, but we could improve the shuffling algorithm: it re-shuffles songs which were already shuffled. You probably copied the MPD code which used to have the same problem. Look up "Fisher Yates shuffle" on Wikipedia, that's what I implemented for MPD recently. If the rest of your code works, I'll merge it, and you can improve it later if you want. We could add a range parameter to MPD's "shuffle" command, that's more efficient than sending n-1 move commands. Max ------------------------------------------------------------------------------ Create and Deploy Rich Internet Apps outside the browser with Adobe(R)AIR(TM) software. With Adobe AIR, Ajax developers can use existing skills and code to build responsive, highly engaging applications that combine the power of local resources and data with the reach of the web. Download the Adobe AIR SDK and Ajax docs to start building applications today-http://p.sf.net/sfu/adobe-com _______________________________________________ Musicpd-dev-team mailing list Musicpd-dev-team@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team
