Hello,
There are 7 new patches available on my repository (
http://repo.or.cz/w/libmpdclient/marc.git) :
- Remove unused macros
- Remove some CamelCase
- Remove CamelCase for mpd_InfoEntity
- Replace 'int' by 'bool' in search commands
- Rewrite 'Search' interface
- Use enum mpd_tag_type instead of int
- Remove some CamelCase
I have two general questions about libmpdclient:
- Do you want to keep mpd_send_* methods centralized in mpd/command.h or do
you prefer to dispatch them by functionnality in the different headers?
(like mpd_send_status in mpd/status.h)
- Which guidelines do you want to put in place for code. For example:
- Use tabs of spaces
- Methods appearing like this:
void mpd_toto (int titi) {
}
or like this:
void mpd_toto (int titi)
{
}
or like this:
void
mpd_toto (int titi)
{
}
- Same question for if/for/while statements
I you define these rules I can propose a patch to have a consistent code
(it's not really the case now :-)).
Regards,
Marc
2009/2/9 Max Kellermann <m...@duempel.org>
> On 2009/02/06 23:48, Marc Pavot <m.pa...@gmail.com> wrote:
> > There are 4 patches available on my repository (
> > http://repo.or.cz/w/libmpdclient/marc.git) :
>
> Thanks Marc, I have merged all.
>
> > - Remove declaration of not implemented functions
> > - stats: make "struct mpd_stats" and "struct mpd_search_stats" opaque
> > - status: make "struct mpd_status" opaque
> > - Add unit tests to libmpclient
>
> The last patch deletes src/example.c, I have modified it, to preserve
> that file. It might be a good example for libmpdclient usage. The
> test cases are not a replacement for it.
>
> I have also fixed the variadic macro usage. You used a non-standard
> way to do it, I switched to C99.
>
> About the opaque patches: I wasn't sure whether this is a good idea.
> Making all structs opaque is good for stabilizing the API (just in
> case the struct has to be changed one day), but there's overhead for
> calling a functions instead of accessing a pointer. I have merged
> your patch anyway, and we might review and reconsider this another
> time.
>
> Max
>
------------------------------------------------------------------------------
Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA
-OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise
-Strategies to boost innovation and cut costs with open source participation
-Receive a $600 discount off the registration fee with the source code: SFAD
http://p.sf.net/sfu/XcvMzF8H
_______________________________________________
Musicpd-dev-team mailing list
Musicpd-dev-team@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team
