Max Kellermann writes: > On 2013/11/02 16:11, j...@dockes.org wrote: > > Hi, > > > > I have uploaded the code for a UPnP Database plugin to > > git://git.musicpd.org/medoc/mpd.git > > One more thing, I had a very quick look at the first commit that adds > code: you added a copy of libexpat. Why that? Why not link this > library, like everybody else does?
I am certainly not adding a copy of libexpat ! I have integrated and modified one file from libexpatmm (a c++ wrapper for libexpat), because this is very simple code, and I did not judge that it was worth the trouble to introduce another dependancy for something almost trivial. I have really no objection in principle to depending on libexpatmm instead, only I'm not completely sure that this is packaged on every platform. All this can be changed, this is a relatively big and complex piece of code, and I certainly don't expect to get it right the first time... With the commits I just added tonight, things mostly work with gmpc and minidlna, with exceptions which will be difficult to implement over UpNP (things based on VisitUniqueTags()). The main thing that I find still missing is "add directory", I'm not too sure how to do this right. And the stats, I need to do the stats too :) jf ------------------------------------------------------------------------------ Android is increasing in popularity, but the open development platform that developers love is also attractive to malware creators. Download this white paper to learn more about secure code signing practices that can help keep Android apps secure. http://pubads.g.doubleclick.net/gampad/clk?id=65839951&iu=/4140/ostg.clktrk _______________________________________________ Musicpd-dev-team mailing list Musicpd-dev-team@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team
