-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hello,
this patch (db238cc23f3bb5c9768d30ae24b99e67a5795203) introduces a segfault upon client connect when mpd is compiled with libwrap enabled. The reason is the removal of g_option_context_parse, which calls g_set_prgname "as a side-effect". Some libwrap specific code in ClientNew.cxx and output/HttpdOutputPlugin.cxx depends on the return value of g_get_prgname not being NULL, in particular the invocation of request_init segfaults if the parameter to RQ_DAEMON is NULL. If g_set_prgname never gets called, g_get_prgname always returns NULL. A obvious means of fixing this would be to pass a copy of argv[0] to request_init. Furthermore, it might be a good idea to check for side-effects when removing glib dependencies in the future, not to mention checking return values for NULL before passing them on. Cheers, Matthias -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJSk4aUAAoJEH6oih43E/yjFWcP/01RaBX3fYQ8/AGZbnQ074BI lpzdicEryT4fLVP/kCgfx74OnwgYX8g1QkmNDqIRReUBlWvf1LSBOVaL8/9a6ana RSxXVzI5q3rKgz+dae1pC5v4hMJU8ZoSilh2AlmSwF5/P0xhHaSdsQ3Am9ApjKAD rKHAXXs50VrHhCqeH3GwxYLN9Bgeu3tNAL7EUATjDqM8I2qgBIKFc6U4lxGHVLO2 7TObzQpDcPCgWGlmgxZnbFmO0ZHp6OBddYD6mDRSYlJw5A/WP8tJIiSaWPC8tQvo 3jPswnjQgVIk+AkPQL5gNNGBWJgOWv0VspuhyIp/2INarGKezpbV4x8hVrRmRRy1 PC9nt2Z0Hss2XurDxl+CfkJxCTID+evJHl7F9J/I9+4x7+iPZBzQGNyxuyhZdCu3 6gHtQg1rhaa3zXWV2IWJUyPYi+KFUkgYmhlxTA/I8VcTWkor/yBquGjLhx7h6xRy kDO/lLdjftzaVyzIOzlYqM9xPpa9fgLSU29FwHbbxteVHp7Oto/aJs/GnHmeXStL qmTKXjxSomIEOM5ZW9FyWX7Dd3oxeblY1OVCUMrn8mhMSIQRiPKWk+86sutYdzrJ Chi9DUiRIFfIpeRV3kngzJKPpPyGcSZIgrmEWJyVnNRKjO0Ie23VkzH8Srz39gGt ogbmULwLIVhH6kcN2Aiy =+jjr -----END PGP SIGNATURE----- ------------------------------------------------------------------------------ Shape the Mobile Experience: Free Subscription Software experts and developers: Be at the forefront of tech innovation. Intel(R) Software Adrenaline delivers strategic insight and game-changing conversations that shape the rapidly evolving mobile landscape. Sign up now. http://pubads.g.doubleclick.net/gampad/clk?id=63431311&iu=/4140/ostg.clktrk _______________________________________________ Musicpd-dev-team mailing list Musicpd-dev-team@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team
