17.12.2013 23:08, j...@dockes.org пишет: > Max Kellermann writes: > > I see many bug fix commit, which fix bugs introduced earlier by > > yourself. This is confusing to read, and makes the repository hard to > > bisect. Please fold those into the commit that introduced the bug. > > Ok, then, I've squashed everything into one commit, as the history was > all bug fixes over the initial code add. >
My minor suggestion: +#include <tr1/unordered_map> +#include <tr1/unordered_set> +using std::tr1::unordered_map; +using std::tr1::unordered_set; I think these headers were created until C++11 standard was defined. Now they are part of standard. Since MPD anyway requires compiler with descent C++11 support (e.g. GCC 4.6+) I think it would be better to avoid legacy tr1 headers/namespaces. -- Denis ------------------------------------------------------------------------------ Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk _______________________________________________ Musicpd-dev-team mailing list Musicpd-dev-team@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team
