Oswald Buddenhagen writes:
On Sun, Nov 22, 2015 at 03:20:52PM +0000, Arnt Gulbrandsen wrote:
Oh really? I think I broke that rule about 365 times per year during the
years I spent at Trolltech.
yes, i know how the code looked like before standards were established.
that's not something to be proud of. ;)
Classic opensource naysaying. Rather resembles that post about the costs of
reformatting, if you don't mind my saying so.
In fact Qt's first coding standards were established before the first line
of code. They came from a library called EDA. (You work with Paul, don't
you? Ask him about EDA sometime.) I attach a file chosen at random to show
how they looked. Go on, tell me what's "not something to be proud of" about
that. If you'd like to compare the style to the other files, they're all in
github.com/arnt/qt-history2.
Trolltech during my time was very much an agile development shop. No
waterfall crap. We were entirely willing to throw code away, and to change
anything that didn't work. Code style was adaptable, all one needed to
adapt it was a good reason. We didn't argue using shadowy naysaing like "I
know how the code looked", we used concrete examples and rationales.
Arnt
/****************************************************************************
** $Id: //depot/qt/main/src/kernel/qrect.cpp#1 $
**
** Implementation of QRect class
**
** Author : Haavard Nord
** Created : 931028
**
** Copyright (C) 1993,1994 by Troll Tech as. All rights reserved.
**
*****************************************************************************/
#define QRECT_C
#include "qrect.h"
#if defined(DEBUG)
static char ident[] = "$Id: //depot/qt/main/src/kernel/qrect.cpp#1 $";
#endif
#if defined(min) || defined(max)
#undef min
#undef max
#endif
static inline QCOOT min( QCOOT a, QCOOT b ) // replaces min macro
{
return a < b ? a : b;
}
static inline QCOOT max( QCOOT a, QCOOT b ) // replaces max macro
{
return a > b ? a : b;
}
// --------------------------------------------------------------------------
// QRect member functions
//
QRect::QRect( const QPoint &topleft, const QPoint &bottomright )
{
x1 = topleft.getX();
y1 = topleft.getY();
x2 = bottomright.getX();
y2 = bottomright.getY();
}
QRect::QRect( const QPoint &topleft, const QSize &size )
{
x1 = topleft.getX();
y1 = topleft.getY();
x2 = x1+size.getWidth()-1;
y2 = y1+size.getHeight()-1;
}
QRect::QRect( QCOOT left, QCOOT top, QCOOT width, QCOOT height )
{
x1 = left;
y1 = top;
x2 = left+width-1;
y2 = top+height-1;
}
bool QRect::isNull() const
{
return x1 == x2-1 && y1 == y2-1;
}
bool QRect::isEmpty() const
{
return x1 > x2 || y1 > y2;
}
bool QRect::isValid() const
{
return x1 <= x2 && y1 <= y2;
}
void QRect::fixup()
{
QCOOT t;
if ( x2 < x1 ) { // swap bad x values
t = x1;
x1 = x2;
x2 = t;
}
if ( y2 < y1 ) { // swap bad y values
t = y1;
y1 = y2;
y2 = t;
}
}
void QRect::setLeft( QCOOT pos )
{
x1=pos;
}
void QRect::setTop( QCOOT pos )
{
y1=pos;
}
void QRect::setRight( QCOOT pos )
{
x2=pos;
}
void QRect::setBottom( QCOOT pos )
{
y2=pos;
}
QPoint QRect::topLeft() const
{
return QPoint( x1, y1 );
}
QPoint QRect::bottomRight() const
{
return QPoint( x2, y2 );
}
QPoint QRect::topRight() const
{
return QPoint( x2, y1 );
}
QPoint QRect::bottomLeft() const
{
return QPoint( x1, y2 );
}
QPoint QRect::center() const
{
return QPoint( (x1+x2)/2, (y1+y2)/2 );
}
void QRect::rect( int *x, int *y, int *w, int *h ) const
{
*x = x1;
*y = y1;
*w = x2-x1+1;
*h = y2-y1+1;
}
void QRect::coords( int *xp1, int *yp1, int *xp2, int *yp2 ) const
{
*xp1 = x1;
*yp1 = y1;
*xp2 = x2;
*yp2 = y2;
}
void QRect::setTopLeft( const QPoint &p )
{
x2 += (p.getX() - x1);
y2 += (p.getY() - y1);
x1 = p.getX();
y1 = p.getY();
}
void QRect::setBottomRight( const QPoint &p )
{
x1 += (p.getX() - x2);
y1 += (p.getY() - y2);
x2 = p.getX();
y2 = p.getY();
}
void QRect::setTopRight( const QPoint &p )
{
x1 += (p.getX() - x2);
y2 += (p.getY() - y1);
x2 = p.getX();
y1 = p.getY();
}
void QRect::setBottomLeft( const QPoint &p )
{
x2 += (p.getX() - x1);
y1 += (p.getY() - y2);
x1 = p.getX();
y2 = p.getY();
}
void QRect::setCenter( const QPoint &p )
{
QCOOT w = x2 - x1;
QCOOT h = y2 - y1;
x1 = p.getX() - w/2;
y1 = p.getY() - h/2;
x2 = x1 + w;
y2 = y1 + h;
}
void QRect::setRect( int x, int y, int w, int h )
{
x1 = x;
y1 = y;
x2 = x+w-1;
y2 = y+h-1;
}
void QRect::setCoords( int xp1, int yp1, int xp2, int yp2 )
{
x1 = xp1;
y1 = yp1;
x2 = xp2;
y2 = yp2;
}
QSize QRect::size() const
{
return QSize( x2-x1+1, y2-y1+1 );
}
QCOOT QRect::width() const
{
return x2-x1+1;
}
QCOOT QRect::height() const
{
return y2-y1+1;
}
void QRect::setSize( const QSize &s )
{
x2 = x1+s.getWidth()-1;
y2 = y1+s.getHeight()-1;
}
bool QRect::contains( const QPoint &p, bool proper ) const
{
if ( proper )
return p.getX() > x1 && p.getX() < x2 &&
p.getY() > y1 && p.getY() < y2;
else
return p.getX() >= x1 && p.getX() <= x2 &&
p.getY() >= y1 && p.getY() <= y2;
}
bool QRect::contains( const QRect &r, bool proper ) const
{
if ( proper )
return r.x1 > x1 && r.x2 < x2 && r.y1 > y1 && r.y2 < y2;
else
return r.x1 >= x1 && r.x2 <= x2 && r.y1 >= y1 && r.y2 <= y2;
}
QRect QRect::unite( const QRect &r ) const
{
QRect tmp;
tmp.setLeft( min( x1, r.x1 ) );
tmp.setRight( max( x2, r.x2 ) );
tmp.setTop( min( y1, r.y1 ) );
tmp.setBottom( max( y2, r.y2 ) );
return tmp;
}
QRect QRect::intersect(const QRect &r ) const
{
QRect tmp;
tmp.x1 = max( x1, r.x1 );
tmp.x2 = min( x2, r.x2 );
tmp.y1 = max( y1, r.y1 );
tmp.y2 = min( y2, r.y2 );
return tmp;
}
bool operator==( const QRect &r1, const QRect &r2 )
{
return r1.x1==r2.x1 && r1.x2==r2.x2 && r1.y1==r2.y1 && r1.y2==r2.y2;
}
bool operator!=( const QRect &r1, const QRect &r2 )
{
return r1.x1!=r2.x1 || r1.x2!=r2.x2 || r1.y1!=r2.y1 || r1.y2!=r2.y2;
}
// --------------------------------------------------------------------------
// QRect stream functions
//
#include "qstream.h"
QStream &operator<<( QStream &s, const QRect &r )
{
return s << (INT16)r.left() << (INT16)r.top()
<< (INT16)r.right() << (INT16)r.bottom();
}
QStream &operator>>( QStream &s, QRect &r )
{
INT16 x1, y1, x2, y2;
s >> x1; s >> y1; s >> x2; s >> y2;
r.setCoords( x1, y1, x2, y2 );
return s;
}
