On Fri, Sep 19, 2014 at 11:57:34AM -0500, David Champion wrote: > I haven't read this thread through completely because it's a bit off > course, but I've picked up on two implemented solutions on this topic: > a VVV patch and a Gary Johnson patch. Can someone discuss how they > differ, whether they conflict, whether either causes problems, whether > they can or should be merged, etc?
I don't think GJ's patch will apply against current dev. The behavior was pretty simple, controlled with a single variable. I had a version that could apply up to maybe 1.5.12 or a bit later. His description from the man page entry: "stuff_all_quoted" When set, mutt will space-stuff all non-empty quoted lines in displayed and generated text/plain; format=flowed attachments, as allowed by RFC 2646. This makes the quoting of format=flowed text easier to read and more consistent with the quoting style traditionally used for format=fixed text. When unset, mutt will space-stuff quoted lines only as required by RFC 2646. AFAICT, the patch used in FreeBSD (vvv one) is pretty similar. There are two configurable variables: quote_empty Type: boolean Default: yes Controls whether or not empty lines will be quoted using "indent_string". quote_quoted Type: boolean Default: no Controls how quoted lines will be quoted. If set, one quote character will be added to the end of existing prefix. Other- wise, quoted lines will be prepended by "indent_string". I'm not sure if the behavior in terms of adding spaces to lines other than the most recent quote level is different, but overall, I think they behave in roughly the same way, other than the additional $quote_empty param, which I don't think GJ's patch messed with at all (the docs specifically only mention "non-empty" quoted lines) One other thing that might make more sense than having it be a separate configuration option is having the behavior simply vary depending on whether $text_flowed is set, similar to how $indent_string is ignored if $text_flowed is set. IMHO, that would give the behavior that most people expect with the least amount of fuss / tweaking. Agree with a lot of what you said in your post; I think at some point, "we" need to just get any serious bugs squashed and get a 1.6 out... at this point, most software vendors are shipping 1.5.x anyway. w
