Hi Steffen,
Yes, a restoration of the substring matching capabilities that were in the
original BSD code was the original point. As it was effectively broken (from
my perspective ;-) in later code in another branch. (That's not to say the BSD
code was not already broken ;-)

Yes, a quick scan of your change looks reasonable.

Perhaps your change might be suitable for the nail code, so it gets into the
redhat releases?
At least I think we have the original intention of the search code clarified
a bit, ie. that you can do a substring search on the whole address ;-)

I'll be in Frankfurt (Airport) then off to Grassellenbach to visit my brother
in a couple of weeks (not sure of the exact date - just for a day or two).
Maybe we should try to meet for a beer as I hurtle through Darmstadt on a slow
train ;-) Consider though that I can't drink as much now as I used to!

Cheers

johnd (Currently Sydney - soon to be London/Portugal/Paris/Grassellenbach ;-)


Steffen Nurpmeso <[email protected]> wrote:
>Hello again John,
>
>i wrote
> |[email protected] (John Dodson) wrote:
> ||For my problem, see,
> ||
> ||        http://sourceforge.net/p/nail/mailman/nail-devel/t\
> ||        hread/[email protected]/
> ||
> ||Still not fixed I think. So it's been broken for a long time.
> ||Where it is in s-nail (after a discussion with Steffen years ago).
>
>Does the attached commit message and diff (against S-nail v14.8.4)
>looks sane to you?  It restores substring matching capabilities
>that the original BSD code provided, which is what you really
>ment, right?  And even with *showname* set you will be able to
>match against an address, even though you won't see it in the
>header overview (POSIX says "any address as shown in a header
>summary shall be matchable in this form").  (With POSIX *allnet*
>set we match against addresses only, too, thus...)
>
> |Thanks for mentioning this again, i didn't get that right in 2012!
>
>Oh yes, interesting thread back then.  Quite off-topic from my
>side of the road :o)
>
>--steffen



------------------------------------------------------------------------------
_______________________________________________
nail-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/nail-devel

Reply via email to