----- Original Message ----- From: "Ian MacLean" <[EMAIL PROTECTED]> To: "Gert Driesen" <[EMAIL PROTECTED]> Cc: "Matthew Mastracci" <[EMAIL PROTECTED]>; "Jaroslaw Kowalski" <[EMAIL PROTECTED]>; "NAnt Developers" <[EMAIL PROTECTED]> Sent: Monday, September 08, 2003 11:52 AM Subject: Re: [nant-dev] [PATCH] New fileset option "fromframework"
> Gert Driesen wrote: > > >After giving it a little more thought (it is actually still very early here, > >so I'm sure if that means anything), I think we actually have multiple > >options : > > > >- use Ian's patch > > > > > > > this has now been comitted. fine. > > >- create an AssemblyReferences (?) class (deriving from FileSet ?) > > > > > > > thats feasible but right now it would only ne neede in compilerbase so > its kinda unnecessary. as mentioned below, it's also useful for others tasks > > >- create an AssemblyReference class with matching collection class > > > >- extend the current FileSet class with an assembly child element (which > >would not support patterns of course) > > > > <references> > > <includes name="..." /> > > <assembly file="System.Web.dll" /> > > <assembly name="log4net, Version=1.2.0.4444, Culture=neutral, > >PublicKeyToken=0038abc9deabfle5" /> > > </references> > > > > > > > this is pretty ugly IMHO - If we have a need to maintain collections of > assemblies specifically then I think a seperate class would be better. > If we need to at all. Yes, I agree. I was just exploring possible options here. > > >We could somehow also support having references using (fully qualified) > >assembly names (NAnt.Core, Version=..., Culture= ..., PublicKeyToken=....), > >but I have no idea how to resolve a fully qualified assembly name to it's > >file path (anyone ?) > > > > > > > you can't - you can only try and mimic what the runtime does in its > probing process. That's what I thought, and I don't think we really need it ... Although the Solution task might need it to locate assemblies stored in the GAC. Right now, it just assumes that assemblies in the gac are always stored in the framework assembly directory, which is ofcourse only correct for system assemblies. > > >IAn's patch would only deal with the compiler tasks, but wouldn't it also be > >useful for other tasks that currently use a FileSet to resolve assembly > >references, for example ndoc, asminfo, nunit, ... > > > > > > > I think it would be better if they used the same technique I employed in > the CompilerBase code. That is a possibility ofcourse, although I'm not sure I like to duplicate the code ... > > >Would this also be useful for non-.NET related tasks, eg. for copying an > >assembly to another directory ? > > > > > > > thats kinda ridiculous. When you are copying files system assemblies > should be treated like any other files. You can use the > currentframeworkdir property to specify the framework path if necessary. > I agree, it was just a question anyway ... Gert ------------------------------------------------------- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf _______________________________________________ nant-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nant-developers
