Martin, Can you also create unit tests for this change (covering both success and failure scenario's) ?
Thanks ! Gert > -----Original Message----- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] On > Behalf Of Martin Aliger > Sent: maandag 13 juni 2005 17:59 > To: nant-developers@lists.sourceforge.net > Subject: [nant-dev] RE: [ nant-Bugs-1210046 ] Fileset fails > when nested in an if block. - 0.85 RC2 > > It seems I cannot add attachment on SF tracker. Silly. > > Regards, > Martin > > > Category: Core > > Group: 0.85 > > Status: Open > > Resolution: None > > Priority: 5 > > Submitted By: Hinrichs (thinrichs) > > Assigned to: Nobody/Anonymous (nobody) > > Summary: Fileset fails when nested in an if block. - 0.85 RC2 > > > > Initial Comment: > > I am running into an error which states "Unknown task > > <fileset>" when I try to nest a fileset in an if block. Of > > course, fileset isnt a task. It's a type, according to the > > NAnt documentation. > > The following code fails (this is not my actual code that is > > failing, but does characterize the bug) > > > > <fileset id="Files"> > > <include name="**"> > > </fileset> > > <if test="{case=='SpecialCase'}> > > <fileset id="Files"> > > <include name="**"/> > > <exclude name="/specialCase/example.txt"> > > </fileset> > > </if> > > > > code such as that above works fine, until case equals > > 'SpecialCase'. Interestingly the following also fails (but > > fails right away). > > > > It still fails on the line in the commented out if block. > > <fileset id="Files"> > > <include name="**"> > > </fileset> > > <! -- <if test="{case=='SpecialCase'}> --> > > <fileset id="Files"> > > <include name="**"/> > > <exclude name="/specialCase/example.txt"> > > </fileset> > > <!-- </if> --> > > > > > ---------------------------------------------------------------------- > > > > Comment By: Martin Aliger (maliger) > > Date: 2005-06-13 17:55 > > > > Message: > > Logged In: YES > > user_id=655297 > > > > its by design in current sources. I just completed patch to > > allow type definitions in nested blocks. Your second example > > is valid though and it works for me (after correcting xml > > inline elements). Could you check it again and if still wrong > > explain it further? > ------------------------------------------------------- This SF.Net email is sponsored by: NEC IT Guy Games. How far can you shotput a projector? How fast can you ride your desk chair down the office luge track? If you want to score the big prize, get to know the little guy. Play to win an NEC 61" plasma display: http://www.necitguy.com/?r=20 _______________________________________________ nant-developers mailing list nant-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nant-developers
