I changed my code. Now I added a full support to custom shortcuts using a configuration file (look at the pull request on github). Now "my" Nautilus accept a configuration file placed in ~/.config/nautilus/shortcuts with a syntax like this:
<control>k gnome-shell --working-directory="%d" <shift><control>u gnome-shell -e 'echo test' ... %d and %f will be replaced with the path of the current directory and with the name of selected files. Nautilus should support shortcuts because it's an important piece of the operative system and it's useful to press some keys to run commands in the current folder with the selected files. I'm not an expert but I've some knowledge about secure programming (to avoid buffer overflow, string format attack, etc.), so I tried to make the code secure, but it's always possible I did some mistakes. Allow Nautilus to run external executable written in a configuration file could be dangerous, but if a malware can write into the configuration file to execute bad scripts this means the user is already infected and the malware can do everything, so this isn't the problem. To stay more secure I check the permissions. In other words Nautilus allow shortcuts only if a user with more priviledges made the configuration file. Basically Nautilus checks if he can read the file and if he can't write it. Let me know what do you think about, Gregorio > Date: Fri, 30 Oct 2015 10:12:23 -0400 > From: csori...@redhat.com > To: de...@outlook.it > CC: nautilus-list@gnome.org > Subject: Re: Adding shortcuts support to Nautilus > > > > ----- Original Message ----- > | Hello, > | > > Hi, I just answered you in Github. > > | I'm a computer science student. I use gnome 3.16 and I like it, but I > | noticied that Nautilus doesn't support custom shortcuts. > | I don't know why you made this decision, but I think a file manager needs > | shortcuts setting to improve productivity and efficiency during the work. I > | really miss a shortcut to open the terminal in the current directory and a > | window to add new custom shortcuts. So I decided to change its source code > | and I submitted a pull request: > | https://github.com/GNOME/nautilus/pull/10 > | > | I read the rules to contribute to the gnome project, but this is not a > bugfix > | so I don't know if its correct to use bugzilla to report this "issue". > | I've the following questions: > | 1) is good submit pull requests on github? or I must use bugzilla? > > We only use bugzilla, so we don't even notice pull request on Github. Sadly > Github > doesn't allow to disable them. > > | 2) Why nobody cares about shortcuts? Do you think to include them in the > near > | future? > > Why do you think nobody cares about shortcuts? Sadly things doesn't magically > get implemented :) > > | > | I know my piece of code could be bad, but I just would like to get a minimal > | shortcuts support in nautilus. > > I will be happy to review and help to get the code merged. However as said in > Github, what > we want is full support for custom shortcuts as we had previous 3.16. But > it's certainly > possible! > > | > | Thank you, > | Gregorio > | > | -- > | nautilus-list mailing list > | nautilus-list@gnome.org > | https://mail.gnome.org/mailman/listinfo/nautilus-list > > Cheers, > Carlos Soriano
-- nautilus-list mailing list nautilus-list@gnome.org https://mail.gnome.org/mailman/listinfo/nautilus-list
