On Wed, 17 Aug 2022 17:06:12 GMT, Daniel Fuchs <[email protected]> wrote:
> Please find here a change that improves SpecialHeadersTest. This test creates
> a large amount of ephemeral clients and has been observed running out of heap
> space in our CI once. This change updates the test to wait for the previous
> HttpClient to be eligible for garbage collection before it creates a new one.
> It also verifies that no outstanding operation are still running on the
> client by the time the client is released.
test/jdk/java/net/httpclient/SpecialHeadersTest.java line 195:
> 193: out.printf(now() + "Task %s failed: %s%n", id, t);
> 194: err.printf(now() + "Task %s failed: %s%n", id, t);
> 195: FAILURES.putIfAbsent("Task " + id, t);
Hello Daniel, is the `putIfAbsent` intentional here? I wouldn't expect the task
id to repeat here (or would there be that many tasks that the `long` id value
overflows and repeats?).
-------------
PR: https://git.openjdk.org/jdk/pull/9908
