On Wed, 17 Aug 2022 17:06:12 GMT, Daniel Fuchs <[email protected]> wrote:
> Please find here a change that improves SpecialHeadersTest. This test creates
> a large amount of ephemeral clients and has been observed running out of heap
> space in our CI once. This change updates the test to wait for the previous
> HttpClient to be eligible for garbage collection before it creates a new one.
> It also verifies that no outstanding operation are still running on the
> client by the time the client is released.
test/jdk/java/net/httpclient/SpecialHeadersTest.java line 284:
> 282: // will be an upgrade
> 283: if (shared != null) {
> 284: TRACKER.track(shared);
Is it intentional that we track a shared client when it is being reset, instead
of tracking it when we create it (a few lines later)? This is unlike a
non-shared instance which we track when we create one.
-------------
PR: https://git.openjdk.org/jdk/pull/9908
