On Thu, 18 Aug 2022 07:31:22 GMT, Jaikiran Pai <[email protected]> wrote:
> Additionally, the `SpecialHeadersTest` would need a copyright year update and > given the kind of changes we are doing in this PR, would it even warrant a > `@bug` id inclusion? This is a test bug. We only add a `@bug` for test changes that test source code changes. Thanks for noticing the copyright. Will fix that. > Overall, I understand these changes but I'm still a bit surprised with the > way this test failed on the CI system especially after how we try to > stop/close the relevant resources (like the SelectorManager thread) as soon > as we realize the client is no longer used and doesn't have any pending > operations. Yes I agree the OOM was surprising. We never had that before and we didn't change anything in the client recently. Maybe that was a new machine with lower specs. Making these tests less greedy in resources is a worthwhile goal however. ------------- PR: https://git.openjdk.org/jdk/pull/9908
