On Mon, 2005-06-20 at 21:15, Robert Story wrote:
> DS> When I submitted the modular logging
> DS> code, this included the minimal changes needed for the agent to
> DS> make use of it. I didn't rip out all of the agent-specific
> DS> logging code and replace it with fully new-style handling.
> Hmmm.. I thought just the internals of logging changed.. what is
> this new-style handling you speak of?
OK - that was probably badly phrased.
The agent has included a whole lot of flags and similar cruft,
relating to the required logging configuration. It was all
this junk that really needed to be tidied up.
All the stuff that you've just got rid of :-)
> DS> if (!get_logh_head())
> DS> snmp_enable_filelog( LOGFILE );
>
> Ok. The only change I'd make there is to actually scan the log handlers
> to make sure one was enabled..
Good point.
Although the logging handlers would presumably need to be explicitly
set up (and explicitly disabled) - disabled handlers wouldn't be
created by default. If the administrator has deliberately turned
off all logging, shouldn't it be left like that?
>
> DS> > 2) only set up the default location if no other logging option was set.
> DS>
> DS> Yup. I agree with that (see above).
>
> Good, That was my choice too. I'll get that in main straightaway.
I haven't read through your changes in detail, but it looks good to me.
What happens if the logging settings are changed dynamically (e.g via
the nsLoggingTable), and then the agent is restarted? Does it revert
to the previous logging configuration (i.e. as at agent start time),
or does it use the settings immediately prior to agent restart?
> Now, what
> about older releases? I think it should go in them too, to fix the
> problems I initially described.
5.2.x - yes, almost certainly
5.0.x - no, definitely not
(but that doesn't include the handler-based logging mechanism anyway)
5.1.x - Ummm.... not sure.
My gut reaction is to say not - it feels too significant a changes.
But it's a sensible change, and probably qualifies as a bug fix.
I'm happy to leave that decision to the 5.1.x line manager :-)
Dave
-------------------------------------------------------
SF.Net email is sponsored by: Discover Easy Linux Migration Strategies
from IBM. Find simple to follow Roadmaps, straightforward articles,
informative Webcasts and more! Get everything you need to get up to
speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click
_______________________________________________
Net-snmp-coders mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
