On Wed, 15 Nov 2006 10:16:18 +0100, Johannes Berg wrote: > > During the "tx handlers" phase that "copy of skb->cb" is extended quite a > > lot with other information determined in the tx handlers. The result is a > > structure that doesn't fit into cb anymore. This is a reason for not using > > cb to pass tx information to drivers. > > Actually, no, it isn't :) The part that is passed to drivers does fit, > only the internal stuff doesn't.
Sorry, I was wrong here. I rechecked it now and starting from the last diet (made by me long time ago, grr) it fits. > > Please note that master interface has been always considered as a hack. Of > > course, this perception can be changed if it's desirable. > > Has it? Simon seems to disagree ;) And I disagree with Simon :-) > > > The master netdev and wiphy create two orthogonal interfaces to > > > userspace that nonetheless pretty much represent the same thing---the > > > underlying hardware. > > > > Yup. > > You just say it like that. Aren't you unhappy about that at all? I wasn't in times when there was no cfg80211. But now... yes, you're right. The sysfs ieee80211 class exports just some interesting informations (we already agreed that add_interface and remove_interface would go away). Feel free to move it wherever you think is appropriate. > I don't think the master interface matters here at all. It's just an > additional netdev that users previously didn't have, but so what? As I said, my pre-cfg80211 arguments are not valid now. > Let me qualify to externally visible problems :) Okay :-) > I've never wanted to change the top part (so far anyway :) ). It's > orthogonal. And whether d80211 behaves as an 802.11 protocol is > something that's visible only in the RX path really, struct packet_type > and associated things. I just said it's a confusing term, nothing against the idea. > > > it becomes too small, we could put a pointer into skb->cb instead and > > > do lifetime management with an skb desctructor. > > > > Not very effective but will work. > > Not really less effective than copying it around all the time as we do > now and then kmalloc()ing it in some circumstances. That's true. Thanks, Jiri -- Jiri Benc SUSE Labs - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
