On 27/04/17 18:03, Michael Drake wrote:
On 26/04/17 18:30, Nick Roberts wrote:
Can you just confirm that NetSurf doesn't save the file if there is an
external hotlist manager?
I don't know, off the top of my head. I'm unfamiliar with the
external hotlist option. If I have time tomorrow I could have
a look at the code.
As far as I can tell there are three differences in behavior when
the RISC OS front end's external hotlist option is enabled:
1. Opening the hotlist will Filer_Run the external application,
rather than opening the NetSurf hotlist manager window.
2. The hotlist_has_url test always returns false for external
hotlists. (Meaning the star in the URL bar will always be
an empty outline, rather than filled yellow, even when the
current page is in the external hotlist.)
3. When adding pages to the hotlist, NetSurf's core hotlist code
isn't informed. This means that the NetSurf won't save the
file when adding URLs.
So NetSurf won't save the hotlist file when adding pages, and
set to use an external hotlist manager.
It looks like the RISC OS front end code for removing pages
from the hotlist first checks whether the core hotlist has
the page, and if it does, it instructs the NetSurf core
hotlist to remove it, rather than the external application.
The remove from hotlist handling has no code to tell an
external hotlist to remove pages.
This means that if this code is called, and the the core
hotlist had the URL, it will remove it, which will cause
NetSurf to save the hotlist file.
I can't remember exactly how the RISC OS UI presents the
interface for removing pages from the hotlist. It might have
been select clicking on a filled URL bar star, or adjust
clicking on a URL bar star, or something else. If the former,
then because of point 2 above, it would not let the remove
page code get called in the first place, so the file wouldn't
get saved.
In any case, I can make it more robust by consulting the
external hotlist option before removing from the hotlist.
Cheers,
