On Fri, 2006-05-26 at 16:29 +0800, Cathy Zhou wrote:
> a. Although it is an existing problem, but I do think the logic in the
> aggr_grp_capab_check() is not correct:
> 
> 1365         if (mac_capab_get(port->lp_mh, MAC_CAPAB_POLL, NULL) !=
> 1366             grp->lg_gldv3_polling) {
> 1367                 return (B_FALSE);
> 1368         }
> 
> if grp->lg_gldv3_polling is B_FALSE but the port being added has 
> MAC_CAPAB_POLL capability, this port should be able to be added into the 
> aggregation.

Indeed.  I'll file a bug (or is there already one filed?).

> 
> b. It seems that the format of /etc/aggregation.conf changes after your 
> work, previous it was like:
> 
> "1       L4      2       bge1/0,bge2/0   auto    off     short"
> 
> but now it changes to
> 
> "1       L4      2       bge1,bge2   auto    off     short"
> 
> and it might causes error messages like "parsing of configuration 
> repository failed". Do you need to think of its impact to system upgrade 
> or bfu?

I've modified dladm to handle either syntax precisely to handle system
upgrade and bfu.  Maybe there's a case I'm not thinking of, but I did
test the upgrade path.

Thanks Cathy,
-Seb


_______________________________________________
networking-discuss mailing list
[email protected]

Reply via email to