Sagun Shakya wrote:
Thank you Doug for reviewing the changes.
Doug McCallum wrote:
ifconfig.c: Not a real issue, but a question. Perrdlpi_exit(const
char *cmd, const char *linkname, int err) just does an exit(1).
Would it be useful in
the future to have it return specific error exits to allow possible
error handling based on exit code in the future?
Sorry I may not have understood your question properly, do you mean
returning exit() with 'err' values or returning with DL_SYSERR error
codes?
With the err passed into thePerrdlpi() function, perhaps changed in range.
This was more a thought that it might be possible to use an appropriate
exit code to allow
a script to do some type of recovery. It may not be useful but I
thought I would ask.
revarp.c: 125: casts for malloc
Is it necessary to have the cast here? The void pointer returned
should be safe to assign without the cast?
It isn't really necessary and may just be my personal preference to
indicate you know what
type you are allocating.
141: since the type of &req would be struct arpreq *,
the addition is going to cause a large pointer
change where you are probably expecting it to be
by size 1.
As I also received comments from Jim, I'll fix this.
Doug
_______________________________________________
networking-discuss mailing list
[email protected]
