Sagun Shakya writes:
> >>>   170: why did waittime change to waitsec?
> >>>   
> >>>       
> >> This was changed to reflect variable waittime was in seconds.
> >>     
> >
> > It seems to me like an unclear change.
> >   
> If the waitime is in seconds isn't this change correct? 

"Waittime" seemed like a clearer name (at least to me) than "waitsec,"
but I suppose I don't really care much.  I was asking to find out why
it needed to be changed, and you've answered that.

> >>> common/libdlpi.c
[...]
> > What happens if dl_qos_offset+dl_qos_length is greater than the actual
> > size of the returned message?  What can check that?
> >
> >   
> Ah.. Just to keep the number of argument passed in dlpi_msg_common 
> dlreplysz can be passed as a pointer and the actual value returned can 
> be passed back that way.
> If that is confusing I'll just add another argument.

Changing the reply size to an in-out parameter would be fine.

> >> 472-473: see comment for line 464
> >>     
> >
> > I'm confused by that.  I'm asking what _checks_ the value.
> >   
> A check for the offset will also be added and the value of the 
> dl_brdcst_length will be made to make sure it is equal to di_physaddrlen.

OK.

-- 
James Carlson, KISS Network                    <[EMAIL PROTECTED]>
Sun Microsystems / 1 Network Drive         71.232W   Vox +1 781 442 2084
MS UBUR02-212 / Burlington MA 01803-2757   42.496N   Fax +1 781 442 1677
_______________________________________________
networking-discuss mailing list
[email protected]

Reply via email to