James Carlson writes: > > >> http://zhadum.east.sun.com/export/build1/ws/sshakya/clearview-libdlpi-onnv/webrev/ > > >> [...] > > > snoop/snoop_capture.c [...] > > > 311: this test isn't needed. The only way to get here when quitting > > > is false is if retval is not success. > > > > > Couldn't we get here if it breaks out of the loop in line 299 due to > > retval is not success but quitting is false? Or I'm not being able to > > follow the logic ? > > Ah, I think the real issue here is that if you stop on error *and* the > 'quitting' flag is set, then you don't want to print out the error. > > So, the easiest (and clearest) thing to do is to combine these two > conditions with &&.
Or just testing 'qutting' and not bothering to test the DLPI return value. If we're not 'quitting', then the only other way to get here is with a non-zero return value. -- James Carlson, KISS Network <[EMAIL PROTECTED]> Sun Microsystems / 1 Network Drive 71.232W Vox +1 781 442 2084 MS UBUR02-212 / Burlington MA 01803-2757 42.496N Fax +1 781 442 1677 _______________________________________________ networking-discuss mailing list [email protected]
