> usr/src/cmd/svc/milestone/net-physical
> - Don't we still need lines 209-218 for wifi drivers?
Good question. If we have any kind of persistence for wifi drivers, it
seems to be working by accident. That is, it relies on drivers not being
unloaded, and the system is free to do so at any moment. And on DEBUG
builds, will do so every 60 seconds: so even with this line present,
when I set speed to 54, reboot and do dladm connect-wifi, then dladm
show-linkprop still shows 36. I guess the question boils down to, should
we preserve something that works by accident? If so, I can add an option
for dladm init-linkprop, like -w or -m wifi, to only initialize
properties for wireless links, and use this option in net-physical.
> usr/src/uts/common/io/mac/mac.c
> - question: what happens if err at line 2947 is EBUSY (e.g., for
> mtu, where driver cannot apply the property just yet)? don't
> we want to do_update in this case, so that the driver can pick
> up the setting next time?
We won't do update when err is EBUSY because of:
do_update = (err == 0);
> - mac_prop_update() should return an error if kmem_zalloc() fails at
> line 3184 (and trickle that error back up from mac_set_prop()
> and mac_set_prop_mac_only())
> - line 3038, check for null return from kmem_zalloc()
kmem_zalloc never fails when called with KM_SLEEP.
> usr/src/lib/libdladm/common/libdladm.h
> - add comments about DLADM_OPT_PROP_MAC_ONLY/DLADM_OPT_PROP_MAC_NAME.
> In terms of their interaction with mac_prop_load(),
> the distinction between the 2 is a bit confusing since both of them
> have the effect of not invoking the driver's setprop routine.
> Are 2 flags needed? It is especially confusing that
> setting MAC_NAME will result in mac_set_prop_mac_only() which is
> not obvious from the constant's name. Would it be cleaner if
> dlmgmtd mapped the MAC_NAME to MAC_ONLY with some comments explaining
> why this was being done?
This been bothering me as well, especially since dld will return EINVAL
when only one of two flags is set. Let me think about it, it feels like
we can do fine with just one flag.
Other comments: agree and will fix.
-Artem
_______________________________________________
networking-discuss mailing list
[email protected]
