Artem Kachitchkine wrote:
> Cathy,
>
>
>> 1. Can you think of any non-physical link driver (or even softmac) could
>> call mac_prop_init()s? I ask this question because it is impossible for
>> pseudo links (aggr, VNIC, or even softmac) to provide the instance
>> argument. That number is assigned by the GLDv3 framework.
>>
>
> This was discussed before and during ARC review and we feel that right
> now mac_prop_init/get will be used by physical drivers only. The need
> for drivers to actively retrieve properties is currently very limited,
> mostly due to some drivers' design defects/peculiarities. Most drivers
> should be able to live without these functions, relying on mc_setprop
> callbacks only.
>
Perhaps this should be a key item to identify for drivers during code
review -- use of anything other than the mc_setprop()/getprop() API
should require justification. If the problem is a driver defect, then
it should be fixable. (If the problem is a requirement to retrieve the
property at start-of-day, during attach, because the hardware needs it
to initialize properly... that's a different case. Hopefully there
aren't too many of those around.)
-- Garrett
_______________________________________________
networking-discuss mailing list
[email protected]
