> I think there may be some value in leaving it there, at least until
> we fix more drivers (the br-pers only has fixes for bge, but nv
> has Brussels support for nge, e1000g, nxge).

I'll see about adding the option to dladm init-linkprop then.

>> We won't do update when err is EBUSY because of:
>>
>>      do_update = (err == 0);
> 
> I'm suggesting that we should do_update in this case,

No, the cached value should always remain in sync with the driver's value.

> or provide
> some way of letting the user update the persistent configuration 
> so that the setting is picked up on the next restart.

'err' will be propagated back to userland. dladm will print the right 
message. When this happens automatically via dlmgmtd, there's nothing we 
can do. Spamming console or syslog is not the right thing either. OTOH, 
this is really a corner case: would happen for mtu in some cases, and 
with the drivers converted to use mac_prop_get(), the mtu will be set 
correctly.

-Artem
_______________________________________________
networking-discuss mailing list
[email protected]

Reply via email to