> > http://cr.opensolaris.org/~artem/pers/ > > A couple simple questions: > > * Can dls_prop_t use the C99 VLA support to avoid having to > subtract 1 when dealing with dls_prop_t's? Or does that > not work for some reason? > > * What uses PROP_HASHSZ in dls_prop.c? > > * Why are i_dls_prop_lock and i_dls_prop_list not `static'? > > * What in dls_prop.c makes use of <sys/door.h> or <sys/softmac.h>? > In general, looks like there some crufty #includes.
All great questions! Especially because it doesn't take me a week to come up with the answers. You're right on all accounts - will fix it. One important thing I forgot to mention. The in-kernel property cache is technically no longer need: we always propagate properties from the ioctl straight into mc_setprop. I see two reasons to retain the cache: - Observability/diagnostics. Using ::dls_prop to list loaded properties is so much easier than digging through each driver's soft state structure. - Potentially useful for future projects (e.g. Crossbow). Cons: - a few dozen lines more code to maintain - a little more kernel memory used I'd rather keep it, but I don't feel strongly about this (or anything, really, except peace of earth). -Artem _______________________________________________ networking-discuss mailing list [email protected]
